Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #536 Update error messages for 'caliper-ethereum' package #1363

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Fix #536 Update error messages for 'caliper-ethereum' package #1363

merged 5 commits into from
Jun 21, 2022

Conversation

0xt3j4s
Copy link
Contributor

@0xt3j4s 0xt3j4s commented May 31, 2022

  • Partially fixes # 536.
  • The error messages are clear and consistent.
  • All the error messages i.e. at debug level, error level, and info level are checked and updated.

davidkel
davidkel requested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

0xt3j4s added 2 commits June 18, 2022 01:09
@0xt3j4s
Fix and organize a few error messages
abc9724 
Signed-off-by: Tezas-6174 <[email protected]>
@0xt3j4s
fix a few bugs
a6eec74 
Signed-off-by: Tezas-6174 <[email protected]>
@0xt3j4s 0xt3j4s requested a review from davidkel June 18, 2022 16:53
davidkel
davidkel requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor nit I'm afraid

@0xt3j4s 0xt3j4s requested a review from davidkel June 21, 2022 18:48
davidkel
davidkel approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit ae23774 into hyperledger-caliper:main Jun 21, 2022
@0xt3j4s 0xt3j4s deleted the caliper-ethereum branch June 21, 2022 18:54
@davidkel davidkel linked an issue Jul 4, 2022 that may be closed by this pull request
Make logging consistent #536
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make logging consistent
2 participants
@0xt3j4s @davidkel